Re: relscan_details.h - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: relscan_details.h
Date
Msg-id CAM3SWZTAMKcRv5Di7RSB6ssbcwJ3iN2TLkbTs8s5q7ZEn0p8Vg@mail.gmail.com
Whole thread Raw
In response to Re: relscan_details.h  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Tue, Sep 17, 2013 at 12:59 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> Personally, I'm not particularly in favor of these kinds of changes.

+1. Experience has shown this kind of effort to be a tarpit. It turns
out that refactoring away compiler dependencies has this kind of
fractal complexity - the more you look at it, the less sense it makes.

I would be in favor of this if there were compelling gains in either
compile time (and like others, I have a pretty high bar for compelling
here), or if the refactoring effort remedied a clear modularity
violation. Though I think it has to happen every once in a while, I'd
suggest about every 5 years as the right interval.

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: relscan_details.h
Next
From: Peter Eisentraut
Date:
Subject: Re: [PATCH] Add use of asprintf()