Obsolete comment within execTuples.c - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Obsolete comment within execTuples.c
Date
Msg-id CAM3SWZSvVzYLVDYZeRdafc8EaZxqe7E1s4D3LjAu2aq6qJ1mjQ@mail.gmail.com
Whole thread Raw
Responses Re: Obsolete comment within execTuples.c
List pgsql-hackers
Header comments within execTuples.c state:
* - ExecutePlan() calls ExecSelect(), which passes the result slot*  to printtup(), which uses slot_getallattrs() to
extractthe*  individual Datums for printing.
 

This isn't true, though - the function ExecSelect() no longer exists.
This is because commit 8a5849b7ff24c637a1140c26fc171e45c9142005
removed it, as infrastructure for data-modifying CTEs. In fact,
ExecutePlan now directly and indifferently calls the receiveSlot.
tcop/dest stuff takes care of calling printtup(), which I guess is
what was originally intended by this comment (by which I mean, that
part probably isn't obsolete).

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pgbench throttling latency limit
Next
From: Tom Lane
Date:
Subject: Re: Obsolete comment within execTuples.c