Minor ON CONFLICT related fixes - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Minor ON CONFLICT related fixes
Date
Msg-id CAM3SWZSfqeYMbWvTYxr2J_ymXY+XkPp=s277yREqk7J5_+ccpg@mail.gmail.com
Whole thread Raw
Responses Re: Minor ON CONFLICT related fixes  (Peter Geoghegan <pg@heroku.com>)
Re: Minor ON CONFLICT related fixes  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Attached patch fixes some issues with ON CONFLICT DO UPDATE/DO
NOTHING. There is a commit message which explains the changes at a
high level. The only real bug fix is around deparsing by ruleutils.c.

Note that the patch proposes to de-support CREATE RULE with an
alternative action involving ON CONFLICT DO UPDATE. Such a rule seems
particularly questionable to me, and I'm pretty sure it was understood
that only ON CONFLICT DO NOTHING should be supported as an action for
a rule (recall that INSERT statements with ON CONFLICT can, in
general, never target relations with rules). At least, I believe
Heikki said that.

Thoughts?
--
Peter Geoghegan

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Multi-xacts and our process problem
Next
From: Peter Geoghegan
Date:
Subject: Re: Minor ON CONFLICT related fixes