Postgres Pro
Downloads
Home   >   mailing lists

Re: tuplesort.c's copytup_index() is dead code - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: tuplesort.c's copytup_index() is dead code
Date
Msg-id CAM3SWZSbJNraCkPNsv_Uh69Ja+DK7xP11DHZEf3RjLgJ12K1KA@mail.gmail.com
Whole thread Raw
In response to Re: tuplesort.c's copytup_index() is dead code  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On Thu, Jun 23, 2016 at 8:35 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> We *do* have regression test coverage, but that code is set up to not
> kick in at any index scale that would be sane to test in the regression
> tests.  See
> https://www.postgresql.org/message-id/12194.1466724741@sss.pgh.pa.us

I'm well aware of that issue. This is the same reason why we don't
have any regression test coverage of external sorts. I don't think
that that's good enough.


-- 
Peter Geoghegan

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: tuplesort.c's copytup_index() is dead code
Next
From: Craig Ringer
Date:
Subject: Re: initdb issue on 64-bit Windows - (Was: [pgsql-packagers] PG 9.6beta2 tarballs are ready)