Re: On conflict update & hint bits - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: On conflict update & hint bits
Date
Msg-id CAM3SWZS=aJcNe=mQsag-xwHa-gruXzmcCeQucwFD14A8JgUhOw@mail.gmail.com
Whole thread Raw
In response to Re: On conflict update & hint bits  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: On conflict update & hint bits  (Konstantin Knizhnik <k.knizhnik@postgrespro.ru>)
List pgsql-hackers
On Sun, Oct 23, 2016 at 2:46 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> What's bothering me is (a) it's less than 24 hours to release wrap and
> (b) this patch changes SSI-relevant behavior and hasn't been approved
> by Kevin.  I'm not familiar enough with that logic to commit a change
> in it on my own authority, especially with so little time for problems
> to be uncovered.

I should point out that I knew that the next set of point releases had
been moved forward much later than you did. I had to work on this fix
during the week, which was pretty far from ideal for me for my own
reasons.

> I'm okay with adding an explicit buffer lock/unlock pair, and in fact
> plan to go have a look at that in a bit.  I'm not okay with doing a
> refactoring that might change the behavior in more ways than that
> under these circumstances.

Fair enough. As long as we do that much, I'm comfortable.

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: On conflict update & hint bits
Next
From: Noah Misch
Date:
Subject: Re: LLVM Address Sanitizer (ASAN) and valgrind support