Re: Is tuplesort_heap_siftup() a misnomer? - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Is tuplesort_heap_siftup() a misnomer?
Date
Msg-id CAM3SWZS3NMT4y-zzDkS0C1vncdsbU=FJiovRQ1ByUjd8sirG7Q@mail.gmail.com
Whole thread Raw
In response to Re: Is tuplesort_heap_siftup() a misnomer?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, Sep 8, 2016 at 2:09 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Well, my vote is that it ain't broke and we shouldn't fix it.

To take a step back, what prompted this whole discussion is the patch
that I wrote that shifts down, replacing calls to
tuplesort_heap_siftup() and tuplesort_heap_insert with one new call to
a function I've called tuplesort_heap_root_displace() (today, Claudio
reports that it makes some of his test queries go 25% faster). This
new function shifts down. It's not clear what I'm supposed to say
about that, given the current understanding. So, in a sense, it's
blocking on this.


-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Preventing deadlock on parallel backup
Next
From: Tom Lane
Date:
Subject: Re: Re: GiST optimizing memmoves in gistplacetopage for fixed-size updates [PoC]