Re: Fix for OpenSSL error queue bug - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Fix for OpenSSL error queue bug
Date
Msg-id CAM3SWZS0iV1HQ2fqNxvmTZm4+hPLAfH=7LeC4znmFX8az=ARMg@mail.gmail.com
Whole thread Raw
In response to Re: Fix for OpenSSL error queue bug  (Peter Geoghegan <pg@heroku.com>)
Responses Re: Fix for OpenSSL error queue bug  (Peter Geoghegan <pg@heroku.com>)
Re: Fix for OpenSSL error queue bug  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
On Mon, Mar 14, 2016 at 4:11 PM, Peter Geoghegan <pg@heroku.com> wrote:
> Yes, with one small difference: I wouldn't be calling ERR_get_error()
> in the common case where SSL_get_error() returns SSL_ERROR_NONE, on
> the theory that skipping that case represents no risk. I'm making a
> concession to Peter E's view that that will calling ERR_get_error()
> more will add useless cycles.

The attached patch is what I have in mind.

I can produce a back-patchable variant of this if you and Peter E.
think this approach is okay.

--
Peter Geoghegan

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Choosing parallel_degree
Next
From: Noah Misch
Date:
Subject: Re: Re: PATCH: Split stats file per database WAS: autovacuum stress-testing our system