Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE.
Date
Msg-id CAM3SWZRjSZwYuVf-9GX6Axu1f51rGEwJ0RmC-j9cncQJG9ZngA@mail.gmail.com
Whole thread Raw
In response to Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE.  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Wed, May 20, 2015 at 6:12 PM, Andres Freund <andres@anarazel.de> wrote:
> You realize there's other instances of this in the same damn function?

I was misled by the argument name, "parsetree" -- in the past,
CreateCommandTag() actually only processed raw parse trees. Beyond
that, I wasn't aware that it is possible to produce a command tag for
every possible representation of an optimizable statement at every
stage of query processing.

I guess that I'll know next time I add a command tag.

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: RFC: Non-user-resettable SET SESSION AUTHORISATION
Next
From: Etsuro Fujita
Date:
Subject: Re: Typo in tablecmds.c