Postgres Pro
Downloads
Home   >   mailing lists

Re: Unsafe use of relation->rd_options without checking its type - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Unsafe use of relation->rd_options without checking its type
Date
Msg-id CAM3SWZRd91khYibv8Ya+Ab1KUOBgFtPbpfUS8_Tv35vvvfWN3Q@mail.gmail.com
Whole thread Raw
In response to Unsafe use of relation->rd_options without checking its type  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On Mon, Oct 31, 2016 at 11:57 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Now that I've seen this I wonder which other uses of rd_options are
> potentially broken.  RelationIsUsedAsCatalogTable() is hardly the
> only macro that is assuming with little justification that it's
> applied to the right kind of reloptions.

It seems worth adding an assertion, at least. I wonder what running
the regression tests with a bunch of similar assertions shows up...


-- 
Peter Geoghegan

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Unsafe use of relation->rd_options without checking its type
Next
From: Jim Nasby
Date:
Subject: Fix bug in handling of dropped columns in pltcl triggers