Re: [sqlsmith] Failed assertion in joinrels.c - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: [sqlsmith] Failed assertion in joinrels.c
Date
Msg-id CAM3SWZRPH99cbLpEzO9ikrwpoeeJYhV7SJ_uCZiiX=0hArKjww@mail.gmail.com
Whole thread Raw
In response to Re: [sqlsmith] Failed assertion in joinrels.c  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Tue, Aug 2, 2016 at 5:05 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> I think that's just making life difficult.  If nothing else, sqlsmith
> hunts around for functions it can call that return internal errors,
> and if we refuse to fix all of them to return user-facing errors, then
> it's just crap for the people running sqlsmith to sift through and
> it's a judgment call whether to fix each particular case.  Even aside
> from that, I think it's much better to have a clear and unambiguous
> rule that elog is only for can't-happen things, not
> we-don't-recommend-it things.

+1.

This also has value in the context of automatically surfacing
situations where "can't happen" errors do in fact happen at scale.

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [sqlsmith] Failed assertion in joinrels.c
Next
From: Tatsuo Ishii
Date:
Subject: Re: Slowness of extended protocol