Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0 - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0
Date
Msg-id CAM3SWZQVLyXhDr1M5qup=0ojUQUSyVEHL42VoCLr-o48AOk6_Q@mail.gmail.com
Whole thread Raw
In response to Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Fri, May 8, 2015 at 11:35 AM, Andres Freund <andres@anarazel.de> wrote:
> I think Peter (on IM) just found a more likely explanation than mine.
>
>                         index_close(idxRel, NoLock);
>                         heap_close(relation, NoLock);
>                         candidates = lappend_oid(candidates, idxForm->indexrelid);
> ...
>
> Yes. idxForm points into idxRel->rd_index.
>
> He's working on a fix for both this and removal of the still unnecessary
> indcheckxmin check.

This was my (last minute) blunder, in case it matters.

Attached patch fixes the bug, and removes the unnecessary indcheckxmin check.

--
Peter Geoghegan

Attachment

pgsql-hackers by date:

Previous
From: Fabrízio de Royes Mello
Date:
Subject: Re: deparsing utility commands
Next
From: Tom Lane
Date:
Subject: Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API)