Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me - Mailing list pgsql-committers

From Peter Geoghegan
Subject Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me
Date
Msg-id CAM3SWZQUwrOW+8VbNNix+mH818=C1jD9LgW6moH82Ef9VV1KnQ@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Mon, Jan 27, 2014 at 6:08 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> "Timed just right"?  I could see it possibly happening due to queryid
> collisions, but I'm not seeing how it would happen absent such a hash
> collision.

Consider what happens when there is a pg_stat_statements_reset() call
query after another query's parse analysis, but before its execution
finishes. That's one obvious way. But you don't even need a reset - a
badly timed entry_dealloc() could do it too.

I don't see what hash collisions have to do with it, though.

--
Peter Geoghegan


pgsql-committers by date:

Previous
From: KONDO Mitsumasa
Date:
Subject: Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me
Next
From: Robert Haas
Date:
Subject: Re: pgsql: Keep pg_stat_statements' query texts in a file, not in shared me