Re: [PATCH] Report exit code from external recovery commands properly - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: [PATCH] Report exit code from external recovery commands properly
Date
Msg-id CAM3SWZQ-w7uGiF5-6gvvm3=4-s6rpPkJRJXiZVaR6d_VX3Zedg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Report exit code from external recovery commands properly  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: [PATCH] Report exit code from external recovery commands properly
List pgsql-hackers
On Sun, Nov 24, 2013 at 5:11 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> How about this?

Hmm. You say:

+        If the command returns a nonzero exit status then a warning log
+        message will be written.  An exception is that if the command was
+        terminated by a signal or an error by the shell (such as command not
+        found), a fatal error will be raised.

But in the case of the archiver, in contrast to the startup process,
this isn't really a big deal. It'll just pick up where it left off.
Whereas the reaper code shuts down the system if this happens in the
startup process. In my opinion that's a distinction that bears
emphasizing.


-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [GENERAL] pg_upgrade ?deficiency
Next
From: Andres Freund
Date:
Subject: Re: Incomplete freezing when truncating a relation during vacuum