Re: pg_dump --pretty-print-views - Mailing list pgsql-hackers

From Jeevan Chalke
Subject Re: pg_dump --pretty-print-views
Date
Msg-id CAM2+6=XgmtEW+FN=XtvtL7XDXC_ua2JCij8iUUct88apPo8xpA@mail.gmail.com
Whole thread Raw
In response to Re: pg_dump --pretty-print-views  (Dimitri Fontaine <dimitri@2ndQuadrant.fr>)
List pgsql-hackers



On Thu, Jan 31, 2013 at 4:40 PM, Dimitri Fontaine <dimitri@2ndquadrant.fr> wrote:
Andrew Dunstan <andrew@dunslane.net> writes:
> Well, we could actually set the wrap value to 0, which would mean always
> wrap. That wouldn't be making any assumption about the user's terminal
> window size ;-)

+1

+1

After looking at both the SQL, I too like wrapped case.
 

> Personally I find the wrapped case MUCH more readable. I guess anything is
> an advance, but turning on PRETTY_INDENT without turning on some level of
> target wrapping seems like a half-done job.

Minor gripe: the CASE WHEN THEN indenting is not ideal:

  CASE
      WHEN (a.attnotnull OR ((t.typtype = 'd'::"char") AND t.typnotnull)) THEN 'NO'::text
      ELSE 'YES'::text
  END)::information_schema.yes_or_no AS is_nullable,

I think the following is easier to read:

  CASE
      WHEN (a.attnotnull OR ((t.typtype = 'd'::"char") AND t.typnotnull))
      THEN 'NO'::text
      ELSE 'YES'::text
  END)::information_schema.yes_or_no AS is_nullable,

But I realise it's not exactly what's being talked about in this thread…

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support



--
Jeevan B Chalke
Senior Software Engineer, R&D
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: +91 20 30589500

Website: www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb

This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message.

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Cascading replication: should we detect/prevent cycles?
Next
From: Mark Kirkwood
Date:
Subject: Re: Cascading replication: should we detect/prevent cycles?