Re: backup manifests - Mailing list pgsql-hackers

From Jeevan Chalke
Subject Re: backup manifests
Date
Msg-id CAM2+6=XRenePvSYT3QOceHAY=Wz1KXf+jr_QBwkVM+uuE1B+3w@mail.gmail.com
Whole thread Raw
In response to Re: backup manifests  (Rushabh Lathia <rushabh.lathia@gmail.com>)
List pgsql-hackers


On Tue, Dec 10, 2019 at 3:29 PM Rushabh Lathia <rushabh.lathia@gmail.com> wrote:

Attaching another version of 0002 patch, as my collogue Jeevan Chalke pointed
few indentation problem in 0002 patch which I sent earlier.  Fixed the same in
the latest patch.

I had a look over the new patch and see no issues. Looks good to me.
Thanks for quickly fixing the review comments posted earlier.

However, here are the minor comments:

1.
@@ -122,6 +133,7 @@ static long long int total_checksum_failures;
 /* Do not verify checksums. */
 static bool noverify_checksums = false;
 
+
 /*
  * The contents of these directories are removed or recreated during server
  * start so they are not included in backups.  The directories themselves are


Please remove this unnecessary change.

Need to run the indentation.

Thanks
--
Jeevan Chalke
Associate Database Architect & Team Lead, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: [HACKERS] advanced partition matching algorithm forpartition-wise join
Next
From: Ranier Vilela
Date:
Subject: RE: [Proposal] Level4 Warnings show many shadow vars