Postgres Pro
Downloads
Home   >   mailing lists

Re: PassDownLimitBound for ForeignScan/CustomScan - Mailing list pgsql-hackers

From Jeevan Chalke
Subject Re: PassDownLimitBound for ForeignScan/CustomScan
Date
Msg-id CAM2+6=XFvUPny1Upt5_3zJN-=0w=1v1jY+qAof9Nyx6ZeW+EbQ@mail.gmail.com
Whole thread Raw
In response to Re: PassDownLimitBound for ForeignScan/CustomScan  (Kouhei Kaigai <kaigai@ak.jp.nec.com>)
Responses Re: PassDownLimitBound for ForeignScan/CustomScan  (Kouhei Kaigai <kaigai@ak.jp.nec.com>)
List pgsql-hackers
Tree view
Hi,

Changes look good to me.

However there are couple of minor issues need to be fixed.

1.
"under" repeated on second line. Please remove.
+    if and when <structname>CustomScanState</> is located under
+    under <structname>LimitState</>; which implies the underlying node is not

2.
Typo: dicsussion => discussion
Please fix.

Apart from this I see no issues.

Thanks

--
Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Bug in VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL
Next
From: Anastasia Lubennikova
Date:
Subject: Re: Refactoring of heapam code.