Re: [sqlsmith] Failed assertion in create_gather_path - Mailing list pgsql-hackers

From Jeevan Chalke
Subject Re: [sqlsmith] Failed assertion in create_gather_path
Date
Msg-id CAM2+6=X=yq-J6DUfO-KkumGZR1dcm065jDbow6cUGbP6HrO33w@mail.gmail.com
Whole thread Raw
In response to Re: [sqlsmith] Failed assertion in create_gather_path  (Andreas Seltenreich <seltenreich@gmx.de>)
Responses Re: [sqlsmith] Failed assertion in create_gather_path  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Hi,

At some places, I have observed that we are adding a partial path even when rel's consider_parallel is false. Due to this, the partial path added has parallel_safe set to false and then later in create_gather_path() assertion fails.

Attached patch to fix that.


On Sun, Apr 8, 2018 at 12:26 AM, Andreas Seltenreich <seltenreich@gmx.de> wrote:
Tom Lane writes:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
>> Andreas Seltenreich wrote:
>>> as of 039eb6e92f:
>>> TRAP: FailedAssertion("!(subpath->parallel_safe)", File: "pathnode.c", Line: 1813)
>
>> Uh, that's pretty strange -- that patch did not touch the planner at
>> all, and the relcache.c changes are pretty trivial.
>
> I don't think Andreas meant that the bug is necessarily new in 039eb6e92f,
> only that that's the version he happened to be testing.

Right.  I'm not testing often enough yet to be able to report on commit
granularity :-).  I'll try for a less ambiguos wording in future
reports.




--
Jeevan Chalke
Technical Architect, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Attachment

pgsql-hackers by date:

Previous
From: Andrew Gierth
Date:
Subject: Re: lazy detoasting
Next
From: Pavel Stehule
Date:
Subject: Re: csv format for psql