On Thu, Sep 24, 2015 at 10:22 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Jeevan Chalke <jeevan.chalke@enterprisedb.com> writes: > On Wed, Sep 23, 2015 at 10:15 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> After a bit more thinking and experimentation, I propose the attached >> patch.
> I had a look over the patch and reviewed it. It is in excellent state to > check-in.
After further thought I decided that the base case for Const/Param/non-foreign-Vars wasn't quite right either. If we don't like the collation we should just set the state to UNSAFE not fail immediately, because it might appear in a context where collation doesn't matter. An example is "var IS NOT NULL".
Make sense.
So I've committed the attached modification of that patch.
Thanks
regards, tom lane
--
Jeevan B Chalke Principal Software Engineer, Product Development EnterpriseDB Corporation The Enterprise PostgreSQL Company
