Re: REFRESH MATERIALIZED VIEW command in PL block hitting Assert - Mailing list pgsql-hackers
From | Jeevan Chalke |
---|---|
Subject | Re: REFRESH MATERIALIZED VIEW command in PL block hitting Assert |
Date | |
Msg-id | CAM2+6=VFgBDNFpcdWGBToQrqNVk6HzXEuED+nJK3tK+wPtMJOA@mail.gmail.com Whole thread Raw |
In response to | Re: REFRESH MATERIALIZED VIEW command in PL block hitting Assert (Kevin Grittner <kgrittn@ymail.com>) |
Responses |
Re: REFRESH MATERIALIZED VIEW command in PL block hitting Assert
|
List | pgsql-hackers |
On Wed, Apr 24, 2013 at 3:04 AM, Kevin Grittner <kgrittn@ymail.com> wrote:
Jeevan Chalke <jeevan.chalke@enterprisedb.com> wrote:
> On Mon, Apr 22, 2013 at 6:41 PM, Andres Freund <andres@2ndquadrant.com> wrote:
>> On 2013-04-22 18:35:04 +0530, Jeevan Chalke wrote:>>> I have observed that following sequence is causing server crash.When the consensus developed to change the syntax from LOAD
>>>
>>> CREATE MATERIALIZED VIEW temp_class_mv AS
>>> SELECT * FROM pg_class
>>> WITH NO DATA;
>>>
>>> CREATE OR REPLACE FUNCTION test_refresh_mv()
>>> RETURNS int
>>> AS $$
>>> BEGIN
>>> REFRESH MATERIALIZED VIEW temp_class_mv;
>>> return 1;
>>> END; $$ LANGUAGE plpgsql;
>>>
>>> SELECT test_refresh_mv();
>>>
>>>
>>> I had a quick look over the crash and it is hitting following Assert in
>>> spi.c:
>>>
>>> else if (IsA(stmt, RefreshMatViewStmt))
>>> {
>>> Assert(strncmp(completionTag,
>>> "REFRESH MATERIALIZED VIEW ", 23) == 0);
>>> _SPI_current->processed = strtoul(completionTag + 23,
>>> NULL, 10);
>>> }
>>>
>>> It seems like we are missing expected value for completionTag in
>>> ExecRefreshMatView()
>> Possibly independent from this issue, but where did that 23 come from?
MATERIALIZED VIEW I failed to noticed the length here when making
the changes for that.I suggest that we just rip out this section of code. Trying to
> BTW, attached is the patch which works well for me, but need details review.
provide a number here is probably all wrong, anyway. As the
features evolve, there may not be a readily accessible rowcount for
this command in all cases.
OK.
Any objections to the attached to fix this issue?
Nope. Fine with me.
Thanks
--
Jeevan B Chalke
Senior Software Engineer, R&D
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91 20 30589500
Website: www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb
This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message.
pgsql-hackers by date: