Re: basebackup.c's sendFile() ignores read errors - Mailing list pgsql-hackers

Hi Jeevan

I had a look at the patch and this seems correct to me.

Few minor comments:

+ /* Check fread() error. */

+ CHECK_FREAD_ERROR(fp, pathbuf);

+

The comments above the macro call at both the places are not necessary as

your macro name itself is self-explanatory.

----------

+ /*

+ * If file is truncated, then we will hit

+ * end-of-file error in which case we don't

+ * want to error out, instead just pad it with

+ * zeros.

+ */

+ if (feof(fp))

The if block does not do the truncation right away, so I think the comment

above can be reworded to explain why we reset cnt?