Re: pg_dump --pretty-print-views - Mailing list pgsql-hackers

From Jeevan Chalke
Subject Re: pg_dump --pretty-print-views
Date
Msg-id CAM2+6=UXPSDq6OnF=yvws4sMy_1WuRx4ByG8M8x=EKNmwpFCGA@mail.gmail.com
Whole thread
In response to Re: pg_dump --pretty-print-views  ("Marko Tiikkaja" <pgmail@joh.to>)
Responses Re: pg_dump --pretty-print-views
List pgsql-hackers
Hi Marko,

I could not apply the patch with git apply, but able to apply it by patch -p1 command.

However, will you please justify the changes done in "xml.out" ? I guess they are not needed.
You might need to configure your sources with libxml.

Also, I am not sure about putting "WRAP_COLUMN_DEFAULT" by default. I will keep that in code committors plate. Rest of the code changes looks good to me.

Thanks

On Sun, Jan 27, 2013 at 6:23 PM, Marko Tiikkaja <pgmail@joh.to> wrote:
On Fri, 18 Jan 2013 07:46:21 +0100, Jeevan Chalke <jeevan.chalke@enterprisedb.com> wrote:
Nice idea.

Marko, just hack ruleutils some thing like this:

Here's a patch attempting to do just that.

The actual code changes were trivial, the patch is mostly just regression tests.

As for the docs, I wasn't entirely happy with what they say about pg_get_viewdef(), but it didn't look like they needed to be changed by this either.


Regards,
Marko Tiikkaja



--
Jeevan B Chalke
Senior Software Engineer, R&D
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: +91 20 30589500

Website: www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb

This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message.

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Number of buckets in a hash join
Next
From: Andres Freund
Date:
Subject: Re: logical changeset generation v4 - Heikki's thoughts about the patch state