Re: pg_dump --pretty-print-views - Mailing list pgsql-hackers

<div dir="ltr">Hi <span class="" style="style">Marko</span>,<br /><div class="gmail_extra"><br /></div><div
class="gmail_extra">Icould not apply the patch with git apply, but able to apply it by patch -p1 command.<br /><br
/></div><divclass="gmail_extra"> However, will you please justify the changes done in "<span class=""
style="style">xml</span>.out"? I guess they are not needed. <br />You might need to configure your sources with <span
class=""style="style">libxml</span>.<br /><br /></div><div class="gmail_extra">Also, I am not sure about putting
"WRAP_COLUMN_DEFAULT"by default. I will keep that in code <span class="" style="style">committors</span> plate. Rest of
thecode changes looks good to me.<br /><br /></div><div class="gmail_extra">Thanks<br /><br /><div
class="gmail_quote">OnSun, Jan 27, 2013 at 6:23 PM, <span class="" style="style">Marko</span> <span class=""
style="style">Tiikkaja</span><span dir="ltr"><<a href="mailto:pgmail@joh.to" target="_blank"><span class=""
style="style">pgmail</span>@<spanclass="" style="style">joh</span>.to</a>></span> wrote:<br /><blockquote
class="gmail_quote"style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div
class="im">OnFri, 18 Jan 2013 07:46:21 +0100, Jeevan Chalke <<a href="mailto:jeevan.chalke@enterprisedb.com"
target="_blank">jeevan.chalke@enterprisedb.<u></u>com</a>>wrote:<br /><blockquote class="gmail_quote"
style="margin:0px0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Nice idea.<br /><br /> Marko,
justhack ruleutils some thing like this:<br /></blockquote><br /></div> Here's a patch attempting to do just that.<br
/><br/> The actual code changes were trivial, the patch is mostly just regression tests.<br /><br /> As for the docs, I
wasn'tentirely happy with what they say about pg_get_viewdef(), but it didn't look like they needed to be changed by
thiseither.<br /><br /><br /> Regards,<br /> Marko Tiikkaja</blockquote></div><br /><br clear="all" /><br />-- <br
/><spanclass="" style="style">Jeevan</span> B <span class="" style="style">Chalke</span><br />Senior Software Engineer,
R&D<br/><span class="" style="style">EnterpriseDB</span> Corporation<br /> The Enterprise <span class=""
style="style">PostgreSQL</span>Company<br /><br />Phone: +91 20 30589500<br /><br />Website: <a
href="http://www.enterprisedb.com"target="_blank">www.<span class="" style="style">enterprisedb</span>.com</a><br
/><spanclass="" style="style">EnterpriseDB</span> Blog: <a href="http://blogs.enterprisedb.com/"
target="_blank">http://blogs.<spanclass="" style="style">enterprisedb</span>.com/</a><br /> Follow us on Twitter: <a
href="http://www.twitter.com/enterprisedb"target="_blank">http://www.twitter.com/<span class=""
style="style">enterprisedb</span></a><br/><br />This e-mail message (and any attachment) is intended for the use of the
individualor entity to whom it is addressed. This message contains information from <span class=""
style="style">EnterpriseDB</span>Corporation that may be privileged, confidential, or exempt from disclosure under
applicablelaw. If you are not the intended recipient or authorized to receive this for the intended recipient, any use,
dissemination,distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have
receivedthis e-mail in error, please notify the sender immediately by reply e-mail and delete this message.
</div></div>