Re: Inconsistency in reporting checkpointer stats - Mailing list pgsql-hackers

From Gregory Stark (as CFM)
Subject Re: Inconsistency in reporting checkpointer stats
Date
Msg-id CAM-w4HPcKgcnPHAiQv6-3cECAM0H0havP2N5qRYddvkqXhaRNQ@mail.gmail.com
Whole thread Raw
In response to Re: Inconsistency in reporting checkpointer stats  (Nitin Jadhav <nitinjadhavpostgres@gmail.com>)
List pgsql-hackers
On Sun, 19 Feb 2023 at 04:58, Nitin Jadhav
<nitinjadhavpostgres@gmail.com> wrote:
>
> > This doesn't pass the tests, because the regression tests weren't adjusted:
> > https://api.cirrus-ci.com/v1/artifact/task/5937624817336320/testrun/build/testrun/regress/regress/regression.diffs
>
> Thanks for sharing this. I have fixed this in the patch attached.

AFAICS this patch was marked Waiting on Author due to this feedback on
Feb 14 but the patch was updated Feb 19 and is still passing today.
I've marked it Needs Review.

I'm not sure if all of the feedback from Bharath Rupireddy and Kyotaro
Horiguchi was addressed.

If there's any specific questions remaining you need feedback on it
would be good to ask explicitly. Otherwise if you think it's ready you
could mark it Ready for Commit.




-- 
Gregory Stark
As Commitfest Manager



pgsql-hackers by date:

Previous
From: "Gregory Stark (as CFM)"
Date:
Subject: Re: Optimizing Node Files Support
Next
From: "Gregory Stark (as CFM)"
Date:
Subject: Re: [PATCH] Add <> support to sepgsql_restorecon