Re: [RFC] overflow checks optimized away - Mailing list pgsql-hackers

From Greg Stark
Subject Re: [RFC] overflow checks optimized away
Date
Msg-id CAM-w4HOeKBJ_Sf6NdHV3XrZxaPBKCEegjYOKR5EeRfMLt+6xNw@mail.gmail.com
Whole thread Raw
In response to Re: [RFC] overflow checks optimized away  (Greg Stark <stark@mit.edu>)
Responses Re: [RFC] overflow checks optimized away  (Heikki Linnakangas <hlinnakangas@vmware.com>)
Re: [RFC] overflow checks optimized away  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Nov 29, 2013 at 7:39 PM, Greg Stark <stark@mit.edu> wrote:
>
> Just as an update I did get gcc to do the wrong thing on purpose. The
> only overflow check that the regression tests find missing is the one
> for int8abs() ie:


Also, one of the places GCC warns about optimizing away an overflow
check (with -fno-wrapv) is inside the localtime.c file from the tz
library. I fixed it in my patch but in fact I checked and it's already
fixed upstream so I'm wondering whether you expect to merge in an
updated tz library? Is there anything surprising about the process or
do you just copy in the files? Would you be happy for someone else to
do it?

-- 
greg



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: MultiXact truncation, startup et al.
Next
From: Tom Lane
Date:
Subject: Re: lock on object is already held