Re: Remove trailing newlines from pg_upgrade's messages - Mailing list pgsql-hackers

From Greg Stark
Subject Re: Remove trailing newlines from pg_upgrade's messages
Date
Msg-id CAM-w4HOUFceDPSu5U0oqMeJg9ApBXvf5ePtT5WTCDjxOK2XHqA@mail.gmail.com
Whole thread Raw
In response to Re: Remove trailing newlines from pg_upgrade's messages  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Remove trailing newlines from pg_upgrade's messages
List pgsql-hackers
On Wed, 15 Jun 2022 at 11:54, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Yeah, that is sort of the inverse problem.  I think those are there
> to ensure that the text appears on a fresh line even if the current
> line has transient status on it.  We could get rid of those perhaps
> if we teach pg_log_v to remember whether it ended the last output
> with a newline or not, and then put out a leading newline only if
> necessary, rather than hard-wiring one into the message texts.

Is the problem that pg_upgrade doesn't know what the utilities it's
calling are outputting to the same terminal?

Another thing I wonder is if during development and testing there
might have been more output from utilities or even the backend going
on that are
not happening now.

-- 
greg



pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: Assorted small doc patches
Next
From: Tom Lane
Date:
Subject: Re: Remove trailing newlines from pg_upgrade's messages