Re: [PATCH] psql: Add tab-complete for optional view parameters - Mailing list pgsql-hackers

On Sun, 29 Jan 2023 at 05:20, Mikhail Gribkov <youzhick@gmail.com> wrote:
>
> The problem is obviously in the newly added second line of the following clause:
>                 COMPLETE_WITH("ALTER COLUMN", "OWNER TO", "RENAME",
>                                           "SET SCHEMA", "SET (", "RESET (");
>
> "set schema" and "set (" alternatives are competing, while completion of the common part "set<space>" leads to a
stringcomposition which does not have the check branch (Matches("ALTER", "VIEW", MatchAny, "SET")).
 
>
> I think it may worth looking at "alter materialized view"  completion tree and making "alter view" the same way.
>
> The new status of this patch is: Waiting on Author

I think this patch received real feedback and it looks like it's clear
where there's more work needed. I'll move this to the next commitfest.
If you plan to work on it this month we can always move it back.


-- 
Gregory Stark
As Commitfest Manager