Re: pgsql: Add ANALYZE into regression tests - Mailing list pgsql-committers

From Greg Stark
Subject Re: pgsql: Add ANALYZE into regression tests
Date
Msg-id CAM-w4HNjztP2hsbHXU1yB8j0bi6iKQmdf3PGRaiYzkofPVupuw@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Add ANALYZE into regression tests  (Stephen Frost <sfrost@snowman.net>)
Responses Re: pgsql: Add ANALYZE into regression tests  (Stephen Frost <sfrost@snowman.net>)
List pgsql-committers

Yeah I think this is OK.

But the original goal seems like it would be easier and better done with an immutable function which lies and calls elog to leak information. That's the actual attack this is supposed to protect against anyways.

That would make the tests more robust against other changes causing failures. Even things like changing explain output formatting for example.

--
greg

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Improve some O(N^2) behavior in window function evaluation.
Next
From: Stephen Frost
Date:
Subject: Re: pgsql: Add ANALYZE into regression tests