Re: psql \d+ and oid display - Mailing list pgsql-hackers

<p dir="ltr">If it's conditional I think "when it matches a guc" is too hard for users to use.<p dir="ltr">I think "say
nothingif oids are off and say something of their on" would be fine. It would result in clutter for users which oids on
bydefault but that's a non default setting. <p dir="ltr">And the consequences of having oids on when they're intended
tobe off are much more likely to be missed our forgotten and need a reminder. If they're off when they need to be on
you'llsurely notice...<p dir="ltr">-- <br /> greg<div class="gmail_quote">On 10 Apr 2014 12:45, "Bruce Momjian" <<a
href="mailto:bruce@momjian.us">bruce@momjian.us</a>>wrote:<br type="attribution" /><blockquote class="gmail_quote"
style="margin:00 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> On Thu, Apr 10, 2014 at 12:23:40PM -0400, Robert
Haaswrote:<br /> > > What might make more sense is this:<br /> > ><br /> > >         if
((tableinfo.relkind== 'r' || tableinfo.relkind == 'm') &&<br /> > >             /*<br /> > >      
      * No need to display default values;  we already display a<br /> > >              * REPLICA IDENTITY marker
onindexes.<br /> > >              */<br /> > >             tableinfo.relreplident != 'i' &&<br />
>>             ((strcmp(schemaname, "pg_catalog") != 0 && tableinfo.relreplident != 'd') ||<br /> >
>             (strcmp(schemaname, "pg_catalog") == 0 && tableinfo.relreplident != 'n')))<br /> ><br />
>Well, this is why I think we should just display it always.  I don't<br /> > think users are going to remember
theexact algorithm for whether or<br /> > not the line gets displayed, so you're just putting yourself in a<br />
>situation where the \d+ output doesn't actually inform the user.  If<br /> > you want to leave it out when it's
"default"and show the "none" line<br /> > for catalog tables, that's OK by me too.  But calling one line of<br />
>output that displays important information "clutter" and only appears<br /> > when the user explicitly requests
verbosemode (with \d+ rather than<br /> > \d) strikes me as as silly.<br /><br /> The issue is that "none" is the
defaultfor system tables and "default"<br /> is the default for user tables.  Tom complained about the "none" for
the<br/> pg_depend display.<br /><br /> I am starting to think I am not going to make everyone happy and we just<br />
needto vote.  Frankly, I think there are enough people who want this<br /> conditionally displayed that I don't even
needa vote.<br /><br /> --<br />   Bruce Momjian  <<a href="mailto:bruce@momjian.us">bruce@momjian.us</a>>      
 <ahref="http://momjian.us" target="_blank">http://momjian.us</a><br />   EnterpriseDB                             <a
href="http://enterprisedb.com"target="_blank">http://enterprisedb.com</a><br /><br />   + Everyone has their own god.
+<br/><br /><br /> --<br /> Sent via pgsql-hackers mailing list (<a
href="mailto:pgsql-hackers@postgresql.org">pgsql-hackers@postgresql.org</a>)<br/> To make changes to your
subscription:<br/><a href="http://www.postgresql.org/mailpref/pgsql-hackers"
target="_blank">http://www.postgresql.org/mailpref/pgsql-hackers</a><br/></blockquote></div>