Re: On login trigger: take three - Mailing list pgsql-hackers

From Gregory Stark (as CFM)
Subject Re: On login trigger: take three
Date
Msg-id CAM-w4HN-Zyxd78+S03puzFPFo2L=B3DOh2umKh__yPaQHv7zew@mail.gmail.com
Whole thread Raw
In response to Re: On login trigger: take three  (Mikhail Gribkov <youzhick@gmail.com>)
Responses Re: On login trigger: take three  (Mikhail Gribkov <youzhick@gmail.com>)
List pgsql-hackers
It looks like the patch is failing a test by not dumping
login_event_trigger_func? I'm guessing there's a race condition in the
test but I don't know. I also don't see the tmp_test_jI6t output file
being preserved in the artifacts anywhere :(

https://cirrus-ci.com/task/6391161871400960?logs=test_world#L2671


[16:16:48.594] # Looks like you failed 1 test of 10350.


# Running: pg_dump --no-sync
--file=/tmp/cirrus-ci-build/src/bin/pg_dump/tmp_check/tmp_test_jI6t/only_dump_measurement.sql
--table-and-children=dump_test.measurement --lock-wait-timeout=180000
postgres
[16:16:27.027](0.154s) ok 6765 - only_dump_measurement: pg_dump runs
.....
[16:16:27.035](0.000s) not ok 6870 - only_dump_measurement: should
dump CREATE FUNCTION dump_test.login_event_trigger_func
[16:16:27.035](0.000s)
[16:16:27.035](0.000s) #   Failed test 'only_dump_measurement: should
dump CREATE FUNCTION dump_test.login_event_trigger_func'
#   at t/002_pg_dump.pl line 4761.
.....
[16:16:48.594] +++ tap check in src/bin/pg_dump +++
[16:16:48.594] [16:16:05] t/001_basic.pl ................ ok 612 ms (
0.01 usr 0.00 sys + 0.24 cusr 0.26 csys = 0.51 CPU)
[16:16:48.594]
[16:16:48.594] # Failed test 'only_dump_measurement: should dump
CREATE FUNCTION dump_test.login_event_trigger_func'
[16:16:48.594] # at t/002_pg_dump.pl line 4761.
[16:16:48.594] # Review only_dump_measurement results in
/tmp/cirrus-ci-build/src/bin/pg_dump/tmp_check/tmp_test_jI6t



pgsql-hackers by date:

Previous
From: "Kumar, Sachin"
Date:
Subject: Initial Schema Sync for Logical Replication
Next
From: Melih Mutlu
Date:
Subject: Re: Allow logical replication to copy tables in binary format