On Sat, Apr 9, 2022 at 8:43 PM Julien Rouhaud <rjuju123@gmail.com> wrote:
On Sat, Apr 09, 2022 at 12:31:23PM -0400, Tom Lane wrote: > Julien Rouhaud <rjuju123@gmail.com> writes: > > On Sat, Apr 09, 2022 at 10:42:12AM -0400, Tom Lane wrote: > >> Also, good luck with "looking in the logs", because by default > >> WARNING-level messages don't go to the postmaster log. > > > I must be missing something because by default log_min_messages is WARNING, and > > AFAICS I do get WARNING-level messages in some vanilla cluster logs, using > > vanilla .psqlrc. > > Ah, sorry, I was looking at the wrong thing namely > log_min_error_statement. The point still holds though: if we emit this > at level WARNING, what will get logged is just the bare message and not > the statement that triggered it. How useful do you think that will be?
Ah right, I did miss that "small detail". And of course I agree, as-is that would be entirely useless and it should be LOG, like the rest of similar features.
The patch does not apply successfully; please rebase the patch.
patching file src/backend/utils/misc/guc.c
Hunk #1 FAILED at 642.
Hunk #2 FAILED at 3943.
2 out of 2 hunks FAILED -- saving rejects to file src/backend/utils/misc/guc.c.rej
patching file src/backend/utils/misc/postgresql.conf.sample
patching file src/include/jit/jit.h
