Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_upgrade: Error out on too many command-line arguments - Mailing list pgsql-hackers

From Ibrar Ahmed
Subject Re: pg_upgrade: Error out on too many command-line arguments
Date
Msg-id CALtqXTcCZ=GXxehmQoTNXXXi5=1r5cV8=yt1P8_p1Mg_v+m+qQ@mail.gmail.com
Whole thread Raw
In response to Re: pg_upgrade: Error out on too many command-line arguments  (Julien Rouhaud <rjuju123@gmail.com>)
List pgsql-hackers
Tree view


On Sun, Aug 25, 2019 at 8:39 PM Julien Rouhaud <rjuju123@gmail.com> wrote:
On Sun, Aug 25, 2019 at 4:30 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> > I propose the attached patch to make pg_upgrade error out on too many
> > command-line arguments.  This makes it match the behavior of other
> > PostgreSQL programs.
>
> +1 ... are we missing this anywhere else?

I did some searching, and oid2name.c is also missing this.

Yes, "oid2name" missing that check too.
 


--
Ibrar Ahmed
Attachment

pgsql-hackers by date:

Previous
From: Vik Fearing
Date:
Subject: Outputting Standard SQL
Next
From: Quentin Rameau
Date:
Subject: Re: [PATCH] Fix missing argument handling in psql getopt