> + * Check that partial aggregate agg has compatibility > > If the `agg` refers to func parameter, the parameter name is aggform I fixed the above typo and made the above comment easy to understand New comment is "Check that partial aggregate function of aggform exsits in remote"
> + int32 partialagg_minversion = PG_VERSION_NUM; > + if (aggform->partialagg_minversion == > PARTIALAGG_MINVERSION_DEFAULT) { > + partialagg_minversion = PG_VERSION_NUM; > > > I am curious why the same variable is assigned the same value twice. It seems > the if block is redundant. > > + if ((fpinfo->server_version >= partialagg_minversion)) { > + compatible = true; > > > The above can be simplified as: return fpinfo->server_version >= > partialagg_minversion; I fixed according to your comment.
