Postgres Pro
Downloads
Home   >   mailing lists

Re: Operation log for major operations - Mailing list pgsql-hackers

From Ted Yu
Subject Re: Operation log for major operations
Date
Msg-id CALte62x_3x4LyFDS3CEtQBBmALFayLTheMQ_swMs7YDprEu4xQ@mail.gmail.com
Whole thread Raw
In response to Re: Operation log for major operations  (Dmitry Koval <d.koval@postgrespro.ru>)
Responses Re: Operation log for major operations
List pgsql-hackers
Tree view


On Thu, Jan 19, 2023 at 1:12 PM Dmitry Koval <d.koval@postgrespro.ru> wrote:
 >The patch does not apply on top of HEAD ...

Thanks!
Here is a fixed version.

Additional changes:
1) get_operation_log() function doesn't create empty operation log file;
2) removed extra unlink() call.

--
With best regards,
Dmitry Koval

Postgres Professional: http://postgrespro.com
Hi,

Copyright (c) 1996-2022

Please update year for the license in pg_controllog.c

+check_file_exists(const char *datadir, const char *path)

There is existing helper function such as:

src/backend/utils/fmgr/dfmgr.c:static bool file_exists(const char *name);

Is it possible to reuse that code ?

Cheers 

pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?)
Next
From: Peter Geoghegan
Date:
Subject: Re: Decoupling antiwraparound autovacuum from special rules around auto cancellation