Postgres Pro
Downloads
Home   >   mailing lists

Re: On login trigger: take three - Mailing list pgsql-hackers

From Ted Yu
Subject Re: On login trigger: take three
Date
Msg-id CALte62wg7NC2cS+KoojuvK7VTn0qdY+O6Q2mTLgw8Oc-yab5BQ@mail.gmail.com
Whole thread Raw
In response to Re: On login trigger: take three  (Mikhail Gribkov <youzhick@gmail.com>)
Responses Re: On login trigger: take three  (Mikhail Gribkov <youzhick@gmail.com>)
List pgsql-hackers
Tree view


On Sat, Dec 17, 2022 at 3:46 AM Mikhail Gribkov <youzhick@gmail.com> wrote:
Hi Nikita,

> Mikhail, I've checked the patch and previous discussion,
> the condition mentioned earlier is still actual:

Thanks for pointing this out! My bad, I forgot to fix the documentation example.
Attached v34 has this issue fixed, as well as a couple other problems with the example code.

--
 best regards,
    Mikhail A. Gribkov
Hi,

bq. in to the system

'in to' -> into

bq. Any bugs in a trigger procedure

Any bugs -> Any bug

+               if (event == EVT_Login)
+                       dbgtag = CMDTAG_LOGIN;
+               else
+                       dbgtag = CreateCommandTag(parsetree);

The same snippet appears more than once. It seems CMDTAG_LOGIN handling can be moved into `CreateCommandTag`.

Cheers

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Perform streaming logical transactions by background workers and parallel apply
Next
From: Ted Yu
Date:
Subject: Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX