Refactor "mutually exclusive options" error reporting code in parse_subscription_options - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Refactor "mutually exclusive options" error reporting code in parse_subscription_options
Date
Msg-id CALj2ACXtoQczfNsDQWobypVvHbX2DtgEHn8DawS0eGFwuo72kw@mail.gmail.com
Whole thread Raw
Responses Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options  (Amul Sul <sulamul@gmail.com>)
List pgsql-hackers
Hi,

parse_subscription_options function has some similar code when
throwing errors [with the only difference in the option]. I feel we
could just use a variable for the option and use it in the error.
While this has no benefit at all, it saves some LOC and makes the code
look better with lesser ereport(ERROR statements. PSA patch.

Thoughts?

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Added missing tab completion for alter subscription set option
Next
From: Amul Sul
Date:
Subject: Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options