Fix a comment in basic_archive about NO_INSTALLCHECK - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Fix a comment in basic_archive about NO_INSTALLCHECK
Date
Msg-id CALj2ACXpjFDiXf-L7AARQ4ppuxiDYSKZjyZb=wOa+cgg0zuWAw@mail.gmail.com
Whole thread Raw
Responses Re: Fix a comment in basic_archive about NO_INSTALLCHECK  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Hi,

It looks like comments in make file and meson file about not running basic_archive tests in NO_INSTALLCHECK mode are wrong. The comments say the module needs to be loaded via shared_preload_libraries=basic_archive, but it actually doesn't. The custom file needs archive related parameters and wal_level=replica. Here's a patch correcting that comment.

Thoughts?

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Attachment

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: running logical replication as the subscription owner
Next
From: Thomas Munro
Date:
Subject: Re: Is RecoveryConflictInterrupt() entirely safe in a signal handler?