Re: Remove redundant variable from transformCreateStmt - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Remove redundant variable from transformCreateStmt
Date
Msg-id CALj2ACXN9sHEaZfu8MtBWVGJ-jZeLe3G52N3TW7WmmgmyhzNxg@mail.gmail.com
Whole thread Raw
In response to Re: Remove redundant variable from transformCreateStmt  (Amul Sul <sulamul@gmail.com>)
Responses Re: Remove redundant variable from transformCreateStmt  (Amul Sul <sulamul@gmail.com>)
List pgsql-hackers
On Mon, Apr 19, 2021 at 9:32 AM Amul Sul <sulamul@gmail.com> wrote:
> Kindly ignore the previous version -- has unnecessary change.
> See the attached.

Thanks for the patch!

How about a slight rewording of the added comment to "Constraints
validation can be skipped for a newly created table as it contains no
data. However, this is not necessarily true for a foreign table."?

You may want to add it to the commitfest if not done already. And I
don't think we need to backpatch this as it's not critical.


With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: PG Docs - CREATE SUBSCRIPTION option list order
Next
From: Thomas Munro
Date:
Subject: Windows default locale vs initdb