Re: Typo in misc_sanity.sql? - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Typo in misc_sanity.sql?
Date
Msg-id CALj2ACXLbBy7LO06eq-z=zrYNRbNDk1KAOsYn81o_QEHYfu4nw@mail.gmail.com
Whole thread Raw
In response to Typo in misc_sanity.sql?  (Japin Li <japinli@hotmail.com>)
List pgsql-hackers
On Mon, Jul 25, 2022 at 1:24 PM Japin Li <japinli@hotmail.com> wrote:
>
>
> Hi, hackers
>
> I found the misc_sanity has a SQL to check system catalogs that
> do not have primary keys, however, in current exceptions it says
> pg_depend, pg_shdepend don't have a unique key.
>
> Should we fix it?

Indeed. There's a clear difference between primary key and unique key.

The patch LGTM.

Regards,
Bharath Rupireddy.



pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Column Filtering in Logical Replication
Next
From: Bharath Rupireddy
Date:
Subject: Re: Is it correct to say, "invalid data in file \"%s\"", BACKUP_LABEL_FILE in do_pg_backup_stop?