Postgres Pro
Downloads
Home   >   mailing lists

Re: Add pg_walinspect function with block info columns - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Add pg_walinspect function with block info columns
Date
Msg-id CALj2ACX0LaZ8o5PN9cXX13wK85md6z4oQiD5NSjQfkz6Msedvg@mail.gmail.com
Whole thread Raw
In response to Re: Add pg_walinspect function with block info columns  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Add pg_walinspect function with block info columns  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
Tree view 
On Mon, Mar 27, 2023 at 9:49 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Sat, Mar 25, 2023 at 12:12:50PM +0900, Michael Paquier wrote:
> > I don't see any need to move this block of code?  This leads to
> > unnecessary diffs, potentially making backpatch a bit harder.  Either
> > way is not a big deal, still..  Except for this bit, 0001 looks fine
> > by me.
>
> FYI, I have gone through 0001 and applied it, after tweaking a bit the
> part about block references so as we have only one
> XLogRecHasAnyBlockRefs, with its StringInfoData used only locally.

Thanks. Here's the v6 patch (last patch that I have with me for
pg_walinspect) for adding per-record info to pg_get_wal_block_info.
Note that I addressed all review comments received so far. Any
thoughts?

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Generate pg_stat_get_xact*() functions with Macros
Next
From: Peter Smith
Date:
Subject: Re: Data is copied twice when specifying both child and parent table in publication