Re: postgres_fdw - should we tighten up batch_size, fetch_size options against non-numeric values? - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: postgres_fdw - should we tighten up batch_size, fetch_size options against non-numeric values?
Date
Msg-id CALj2ACWPptcAR0Uaye6KdFnM2xp5FXWJhO+mCoo-sSoc7_3w2g@mail.gmail.com
Whole thread Raw
In response to Re: postgres_fdw - should we tighten up batch_size, fetch_size options against non-numeric values?  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: postgres_fdw - should we tighten up batch_size, fetch_size options against non-numeric values?  (Fujii Masao <masao.fujii@oss.nttdata.com>)
List pgsql-hackers
On Thu, Jul 1, 2021 at 8:23 AM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> The recent commit 61d599ede7 documented that the type of those options is
> floating point. But the docs still use "is a numeric value" in the descriptions
> of them. Probably it should be replaced with "is a floating point value" there.
> If we do this, isn't it better to use "floating point" even in the error message?

Agreed. PSA v5 patch.

Regards,
Bharath Rupireddy.

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Skipping logical replication transactions on subscriber side
Next
From: Noah Misch
Date:
Subject: Re: Preventing abort() and exit() calls in libpq