Postgres Pro
Downloads
Home   >   mailing lists

Re: Simplify xlogreader.c with XLogRec* macros - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Simplify xlogreader.c with XLogRec* macros
Date
Msg-id CALj2ACWOUm9yG-JKqAoQLdt1gUmeyNChhQBsxkXQpE+bnCVBbw@mail.gmail.com
Whole thread Raw
In response to Re: Simplify xlogreader.c with XLogRec* macros  (邱宇航 <iamqyh@gmail.com>)
Responses Re: Simplify xlogreader.c with XLogRec* macros
List pgsql-hackers
Tree view 
On Tue, Oct 31, 2023 at 4:12 PM 邱宇航 <iamqyh@gmail.com> wrote:
>
> >
> > I thought these can also be rewrite to:
> >
> > if (!XLogRecHasBlockRef(record, block_id))
>
> Oops, I missed that. New version is attached.

+1. Indeed a reasonable change. The attached v2 patch LGTM.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Fix search_path for all maintenance commands
Next
From: John Morris
Date:
Subject: Re: Including Doxyfile and Meson script for docs into main source tree