Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation
Date
Msg-id CALj2ACVp9vOeEYnw6B3=3B58_tUECLosGETPTdZG24O3ywzNMQ@mail.gmail.com
Whole thread Raw
In response to Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On Wed, Jul 7, 2021 at 5:35 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> Attaching v6 patch rebased onto the latest master.

I came across a recent commit 81d5995 and have used the same error
message for temporary and unlogged tables. Also added, test cases to
cover these error cases for foreign, temporary, unlogged and system
tables with CREATE PUBLICATION command. PSA v7.

commit 81d5995b4b78017ef9e5c6f151361d1fb949924c
Author: Peter Eisentraut <peter@eisentraut.org>
Date:   Wed Jul 21 07:40:05 2021 +0200

    More improvements of error messages about mismatching relkind

Regards,
Bharath Rupireddy.

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [Doc] Tiny fix for regression tests example
Next
From: Michael Paquier
Date:
Subject: Re: CREATE SEQUENCE with RESTART option