Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds? - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?
Date
Msg-id CALj2ACVhY9TU-TVVYpoZf9XCyWEspXip1=QV981Pg8XFx=xeRg@mail.gmail.com
Whole thread Raw
In response to Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?  (Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>)
List pgsql-hackers
On Mon, Dec 13, 2021 at 5:09 AM Juan José Santamaría Flecha
<juanjo.santamaria@gmail.com> wrote:
>
>
> On Thu, Oct 21, 2021 at 7:21 AM Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
>>
>>
>> Here's the documentation v1 patch that I've come up with. Please review it.
>>
> There's a typo:
> +   To run an arbitrary TAP test set, run <command>vcregress taptest</command>
> +   comamnd. For example, use the following command for running subcription TAP
> +   tests:
> s/comamnd/command/
>
> But also the wording, I like better what vcregress prints as help, so something like:
> +   You can use <command>vcregress taptest TEST_DIR</command> to run an
> +   arbitrary TAP test set, where TEST_DIR is a required argument pointing to
> +   the directory where the tests reside. For example, use the following
> +   command for running the subcription TAP tests:

Thanks for the comments. Above looks good to me, changed that way, PSA v2.

Regards,
Bharath Rupireddy.

Attachment

pgsql-hackers by date:

Previous
From: Konstantin Knizhnik
Date:
Subject: Race condition in TransactionIdIsInProgress
Next
From: Swaha Miller
Date:
Subject: Re: support for CREATE MODULE