Re: Make all Perl warnings fatal - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Make all Perl warnings fatal
Date
Msg-id CALj2ACVT9BAOVZ3zDdN24NORjPdG9WkyPAJtRsE=Hq834rx+zA@mail.gmail.com
Whole thread Raw
In response to Re: Make all Perl warnings fatal  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: Make all Perl warnings fatal
List pgsql-hackers
On Sat, Dec 30, 2023 at 12:57 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>
> committed

With the commit c5385929 converting perl warnings to FATAL, use of
psql/safe_psql with timeout parameters [1] fail with the following
error:

Use of uninitialized value $ret in bitwise and (&) at
/home/ubuntu/postgres/src/test/recovery/../../../src/test/perl/PostgreSQL/Test/Cluster.pm
line 2015.

Perhaps assigning a default error code to $ret instead of undef in
PostgreSQL::Test::Cluster - psql() function is the solution.

[1]
use strict;
use warnings FATAL => 'all';
use PostgreSQL::Test::Cluster;
use PostgreSQL::Test::Utils;
use Test::More;

my $node = PostgreSQL::Test::Cluster->new('test');
$node->init;
$node->start;

my ($stdout, $stderr, $timed_out);
my $cmdret = $node->psql('postgres', q[SELECT pg_sleep(600)],
          stdout => \$stdout, stderr => \$stderr,
          timeout => 5,
          timed_out => \$timed_out,
          extra_params => ['--single-transaction'],
          on_error_die => 1);
print "pg_sleep timed out" if $timed_out;

done_testing();

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Nazir Bilal Yavuz
Date:
Subject: Re: Show WAL write and fsync stats in pg_stat_io
Next
From: Alexander Korotkov
Date:
Subject: Re: POC: GROUP BY optimization