Re: Allow pg_signal_backend members to use pg_log_backend_memory_stats(). - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Allow pg_signal_backend members to use pg_log_backend_memory_stats().
Date
Msg-id CALj2ACVOhXjSzGGcONqss0ucdEZ2jBdUjioTBrjS_wtwP1r=xQ@mail.gmail.com
Whole thread Raw
In response to Re: Allow pg_signal_backend members to use pg_log_backend_memory_stats().  (Jeff Davis <pgsql@j-davis.com>)
List pgsql-hackers
On Sun, Oct 24, 2021 at 10:34 PM Jeff Davis <pgsql@j-davis.com> wrote:
> > 5) The following change is being handled in the patch at [3], I know
> > it is appropriate to have it in this patch, but please mention it in
> > the commit message on why we do this change. I will remove this
> > change
> > from my patch at [3].
> > -SELECT * FROM pg_log_backend_memory_contexts(pg_backend_pid());
> > +SELECT pg_log_backend_memory_contexts(pg_backend_pid());
>
> What would you like me to mention?

Something like below in the commit message would be good:
"While on this, change the way the tests use pg_log_backend_memory_contexts()
Usually for functions, we don't use "SELECT-FROM-<<function>>",
we just use "SELECT-<<function>>"."

Regards,
Bharath Rupireddy.



pgsql-hackers by date:

Previous
From: Amul Sul
Date:
Subject: Re: TAP test for recovery_end_command
Next
From: Bharath Rupireddy
Date:
Subject: Re: Allow pg_signal_backend members to use pg_log_backend_memory_stats().