Re: Cleanup - adjust the code crossing 80-column window limit - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Cleanup - adjust the code crossing 80-column window limit
Date
Msg-id CALj2ACVOAmBB9HtBdWXyTgWvzY7NchodNb8NbC1O_DY-mgvg7A@mail.gmail.com
Whole thread Raw
In response to Cleanup - adjust the code crossing 80-column window limit  (Amul Sul <sulamul@gmail.com>)
Responses Re: Cleanup - adjust the code crossing 80-column window limit
List pgsql-hackers
changes look good to me.

one comment: instead of having block variables onexit, in the while
loops in shmem_exit, can we have a single local variable defined at
the start of the shmem_exit function
and reuse them in the while loops? same comment for onexit block
variable in proc_exit_prepare() function.

Patch applies successfully on commit - 4315e8c23b9a897e12fcf91de7bfd734621096bf

make check and make check-world runs are clean.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com


On Wed, Jul 1, 2020 at 12:31 PM Amul Sul <sulamul@gmail.com> wrote:
>
> Hi,
>
> Attached patch makes an adjustment to ipc.c code to be in the 80-column window.
>
> Regards,
> Amul
>



pgsql-hackers by date:

Previous
From: Dave Cramer
Date:
Subject: Re: Binary support for pgoutput plugin
Next
From: Etsuro Fujita
Date:
Subject: Re: estimation problems for DISTINCT ON with FDW