replace IDENTIFY_SYSTEM code in receivelog.c with RunIdentifySystem() - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject replace IDENTIFY_SYSTEM code in receivelog.c with RunIdentifySystem()
Date
Msg-id CALj2ACVKKYUMC8GE72Y7BP9g1batrrq3sEwUh+1_i2krWZC_2Q@mail.gmail.com
Whole thread Raw
Responses Re: replace IDENTIFY_SYSTEM code in receivelog.c with RunIdentifySystem()
List pgsql-hackers
Hi,

I see a couple of improvements to receivelog.c and pg_receivewal.c:

1) ReceiveXlogStream in receivelog.c has a duplicate code to execute
IDENTIFY_SYSTEM replication command on the server which can be
replaced with RunIdentifySystem().
2) bool returning ReceiveXlogStream() in pg_receivewal.c is being used
without type-casting its return return value which might generate a
warning with some compilers. This kind of type-casting is more common
in other places in the postgres code base.

Attaching a patch to fix the above. Thoughts?

Regards,
Bharath Rupireddy.

Attachment

pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: Fix around conn_duration in pgbench
Next
From: Yugo NAGATA
Date:
Subject: Re: Fix around conn_duration in pgbench