Re: Deduplicate min restart_lsn calculation code - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Deduplicate min restart_lsn calculation code
Date
Msg-id CALj2ACUqex0S8wYxrm5_Qz4NYnsqs6s8JMYeeg2qO35kS7hUAA@mail.gmail.com
Whole thread Raw
In response to Re: Deduplicate min restart_lsn calculation code  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
On Thu, Jan 6, 2022 at 11:54 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> On 2022-Jan-06, Bharath Rupireddy wrote:
>
> > Hi,
> >
> > It seems like the two functions ReplicationSlotsComputeRequiredLSN and
> > ReplicationSlotsComputeLogicalRestartLSN more or less does the same
> > thing which makes me optimize (saving 40 LOC) it as attached. I'm
> > pretty much okay if it gets rejected on the grounds that it creates a
> > lot of diff with the older versions and the new API may not look
> > nicer, still I want to give it a try.
> >
> > Thoughts?
>
> Hmm, it seems sensible to me.  But I would not have the second boolean
> argument in the new function, and instead have the caller save the
> return value in a local variable to do the XLogSetReplicationSlotMinimumLSN
> step separately.  Then the new function API is not so strange.

Thanks for taking a look at it. Here's the v2 patch, please review.

Regards,
Bharath Rupireddy.

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Add spin_delay() implementation for Arm in s_lock.h
Next
From: "houzj.fnst@fujitsu.com"
Date:
Subject: RE: row filtering for logical replication