Re: Make mesage at end-of-recovery less scary. - Mailing list pgsql-hackers

From Ashwin Agrawal
Subject Re: Make mesage at end-of-recovery less scary.
Date
Msg-id CALfoeiuCe7uS8=OAH-XSfqzG4oa2i++3z6B5iE2u_BuAWZaZfA@mail.gmail.com
Whole thread Raw
In response to Re: Make mesage at end-of-recovery less scary.  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: Make mesage at end-of-recovery less scary.  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Mon, Mar 23, 2020 at 2:37 AM Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
On 2020-03-05 08:06, Kyotaro Horiguchi wrote:
> | [20866] LOG:  replication terminated by primary server
> | [20866] DETAIL:  End of WAL reached on timeline 1 at 0/30001C8.
> | [20866] FATAL:  could not send end-of-streaming message to primary: no COPY in progress
> | [20851] LOG:  reached end of WAL at 0/30001C8 on timeline 1 in archive during standby mode
> | [20851] DETAIL:  invalid record length at 0/30001C8: wanted 24, got 0
>
> I changed the above to the below, which looks more adequate.
>
> | [24271]  LOG:  replication terminated by primary server on timeline 1 at 0/3000240.
> | [24271]  FATAL:  could not send end-of-streaming message to primary: no COPY in progress
> | [24267]  LOG:  reached end of WAL at 0/3000240 on timeline 1 in archive during standby mode
> | [24267]  DETAIL:  invalid record length at 0/3000240: wanted 24, got 0

Is this the before and after?  That doesn't seem like a substantial
improvement to me.  You still get the "scary" message at the end.

+1 I agree it still reads scary and doesn't seem improvement.

Plus, I am hoping message will improve for pg_waldump as well?
Since it reads confusing and every-time have to explain new developer it's expected behavior which is annoying.

pg_waldump: fatal: error in WAL record at 0/1553F70: invalid record length at 0/1553FA8: wanted 24, got 0

pgsql-hackers by date:

Previous
From: Nikita Glukhov
Date:
Subject: Re: SQL/JSON: JSON_TABLE
Next
From: Tom Lane
Date:
Subject: Re: Assert() failures during RI checks