Re: Create TOAST table only if AM needs - Mailing list pgsql-hackers

From Ashwin Agrawal
Subject Re: Create TOAST table only if AM needs
Date
Msg-id CALfoeisJn=+0uGA3qTyZE4aK7GwgVpLxxFNciXMO4_bTDqfNjQ@mail.gmail.com
Whole thread Raw
In response to Re: Create TOAST table only if AM needs  (Andres Freund <andres@anarazel.de>)
Responses Re: Create TOAST table only if AM needs  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers

On Fri, May 17, 2019 at 1:51 PM Andres Freund <andres@anarazel.de> wrote:

>  /* ------------------------------------------------------------------------
>   * Planner related callbacks for the heap AM
> @@ -2558,6 +2615,8 @@ static const TableAmRoutine heapam_methods = {

>       .relation_estimate_size = heapam_estimate_rel_size,

> +     .needs_toast_table = heapam_needs_toast_table,
> +

I'd rather see this have a relation_ prefix.

+1 to overall patch with that comment incorporated. This seems simple enough to incorporate for v12. Though stating that blind-folded with what else is remaining to be must done for v12.

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: New vacuum option to do only freezing
Next
From: Ashwin Agrawal
Date:
Subject: Re: Create TOAST table only if AM needs