Re: heapam_index_build_range_scan's anyvisible - Mailing list pgsql-hackers

From Ashwin Agrawal
Subject Re: heapam_index_build_range_scan's anyvisible
Date
Msg-id CALfoeis6=8ehuR=VNtHvj3z16cYfCwPdTcpaxU+sfSUJ5QgR3g@mail.gmail.com
Whole thread Raw
In response to heapam_index_build_range_scan's anyvisible  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: heapam_index_build_range_scan's anyvisible
List pgsql-hackers

On Fri, Jun 7, 2019 at 1:19 PM Robert Haas <robertmhaas@gmail.com> wrote:
I spent some time today studying heapam_index_build_range_scan and
quickly reached the conclusion that it's kind of a mess.

While at it might be helpful and better to also decouple HeapTuple dependency for
IndexBuildCallback. Currently, all AM needs to build HeapTuple in index_build_range_scan function. I looked into all the callback functions and only htup->t_self is used from heaptuple in all the functions (unless I missed something). So, if seems fine will be happy to write patch to make that argument ItemPointer instead of HeapTuple?

pgsql-hackers by date:

Previous
From: "Goel, Dhruv"
Date:
Subject: Re: Avoiding deadlock errors in CREATE INDEX CONCURRENTLY
Next
From: David Rowley
Date:
Subject: Re: Should we warn against using too many partitions?